conflict-set: fixupMaxVersion misses Node256 children past the first 16
We calculated the max of 16 versions in the wrong array, leading reads to incorrectly report Commit.
Ideas and projects from former FoundationDB contributor Andrew Noyes
Make clangd check your asserts even with -DNDEBUG
A two-line .clangd file restores autocomplete and type checking inside assert() when your compile_commands.json was generated from a Release build.
If a sentence about C++ starts with "On x86,", stop listening.
Or, where in the C++ standard does it mention x86?
conflict-set: move-assignment leaks the old impl
The move-assignment operator of the shipped ConflictSet implementation overwrote the internal impl pointer without first destroying the old one, leaking everything it owned.
conflict-set: advance version even if no writes
In versions v0.0.12 and earlier, the documentation in ConflictSet.h is ambiguous about the behavior of a call to check or setOldestVersion with a version greater than the version of the last call to addWrites.
A bug finds its way into conflict-set v0.0.7
Here at weaselab we take correctness seriously, so when a release contains a correctness issue it's worth taking the time to reflect on how it happened.
What is Weaselab?
Weaselab is mostly just a domain name, but it's also where former FoundationDB contributor Andrew Noyes publishes ideas and projects.